Repository navigation
Support custom mapping files in X12Reader - #81
Open
AbhinavMir wants to merge 1 commit into
Open
AbhinavMir wants to merge 1 commit into
AbhinavMir wants to merge 1 commit into
Conversation
X12Reader was limited to the standards enumerated in FileType. Add an X12Mapping interface (transaction definition + expected ANSI version) so callers can parse files against a mapping that is not built in. - FileType now implements X12Mapping. - CustomX12Mapping builds an X12Mapping from a user-supplied mapping XML stream and version string, reusing the same secured XStream loader. - X12Reader gains constructors accepting any X12Mapping (File, InputStream, Reader, with optional Charset); the existing FileType constructors delegate to them, so the public API is unchanged. Adds tests parsing a file through a custom mapping and verifying the result matches the built-in FileType, plus a version-mismatch rejection test. README documents the new usage.
Member
|
@angelaszek can you please take a look? |
Member
|
Please fix merge conflicts. |
Collaborator
|
This looks ok to me once the merge conflicts are resolved. It will make the library more flexible if the pre-defined mappings don't work for a particular purpose but shouldn't affect how the library is used in existing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.